Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg to new mainline commit and instructions #78548

Merged
merged 1 commit into from
Dec 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/vcpkg_ports/sdl2/deps.patch

This file was deleted.

130 changes: 0 additions & 130 deletions .github/vcpkg_ports/sdl2/portfile.cmake

This file was deleted.

8 changes: 0 additions & 8 deletions .github/vcpkg_ports/sdl2/usage

This file was deleted.

25 changes: 0 additions & 25 deletions .github/vcpkg_ports/sdl2/vcpkg.json

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/msvc-full-features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
id: runvcpkg
with:
vcpkgDirectory: '${{ runner.workspace }}/b/vcpkg'
vcpkgGitCommitId: '66444e13a86da7087ee24c342f91801cc6eb9877'
vcpkgGitCommitId: '3b57fb2e1ff55613db14d2aaf0a30529289c7050'

- name: Integrate vcpkg
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
id: runvcpkg
with:
vcpkgDirectory: '${{ runner.workspace }}/b/vcpkg'
vcpkgGitCommitId: '66444e13a86da7087ee24c342f91801cc6eb9877'
vcpkgGitCommitId: '3b57fb2e1ff55613db14d2aaf0a30529289c7050'
- name: Install dependencies (windows msvc) (3/4)
if: runner.os == 'Windows'
run: |
Expand Down
6 changes: 3 additions & 3 deletions doc/COMPILING/COMPILING-VS-VCPKG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Steps from current guide were tested on Windows 10 (64 bit), Visual Studio 2019

2. Install `Git for Windows` (installer can be downloaded from [Git homepage](https://git-scm.com/)).

3. Install and configure `vcpkg`. If you already have `vcpkg` installed, you should update it to at least commit `66444e13a86da7087ee24c342f91801cc6eb9877` (the most recent tested good revision) and rerun `.\bootstrap-vcpkg.bat` as described:
3. Install and configure `vcpkg`. If you already have `vcpkg` installed, you should update it to at least commit `3b57fb2e1ff55613db14d2aaf0a30529289c7050` (the most recent tested good revision) and rerun `.\bootstrap-vcpkg.bat` as described:

***WARNING: It is important that, wherever you decide to clone this repo, the path does not include whitespace. That is, `C:/dev/vcpkg` is acceptable, but `C:/dev test/vcpkg` is not.***

Expand All @@ -31,18 +31,18 @@ In a `cmd.exe` shell:
REM cd to the appropriate folder first
git clone https://github.com/Microsoft/vcpkg.git
cd vcpkg
git checkout 3b57fb2e1ff55613db14d2aaf0a30529289c7050
.\bootstrap-vcpkg.bat -disableMetrics
.\vcpkg integrate install
git checkout 66444e13a86da7087ee24c342f91801cc6eb9877
```
In a Git Bash shell, the commands are almost the same except the filesystem path separator is `/` instead of `\`.
```cmd
# cd to the appropriate folder first
git clone https://github.com/Microsoft/vcpkg.git
cd vcpkg
git checkout 3b57fb2e1ff55613db14d2aaf0a30529289c7050
./bootstrap-vcpkg.bat -disableMetrics
./vcpkg.exe integrate install
git checkout 66444e13a86da7087ee24c342f91801cc6eb9877
```

## Cloning and compilation:
Expand Down
10 changes: 6 additions & 4 deletions msvc-full-features/Cataclysm-common.props
Original file line number Diff line number Diff line change
Expand Up @@ -104,23 +104,25 @@
$(ProjectDir)vcpkg_installed\$(VcpkgTripet)\$(VcpkgTriplet)\lib;%(AdditionalLibraryDirectories)
</AdditionalLibraryDirectories>
<AdditionalDependencies>
brotlicommon-static.lib;
brotlidec-static.lib;
brotlienc-static.lib;
brotlicommon.lib;
brotlidec.lib;
brotlienc.lib;
bz2$(VcpkgLibSuffix).lib;
FLAC.lib;
FLAC++.lib;
freetype$(VcpkgLibSuffix).lib;
jpeg.lib;
libpng16$(VcpkgLibSuffix).lib;
libwavpack.lib;
libxmp-static.lib;
modplug.lib;
mpg123.lib;
ogg.lib;
out123.lib;
pdcurses.lib;
SDL2_image-static$(VcpkgLibSuffix).lib;
SDL2_mixer-static$(VcpkgLibSuffix).lib;
SDL2_ttf.lib;
SDL2_ttf$(VcpkgLibSuffix).lib;
SDL2-static$(VcpkgLibSuffix).lib;
syn123.lib;
turbojpeg.lib;
Expand Down
7 changes: 1 addition & 6 deletions msvc-full-features/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,5 @@
},
"sdl2-ttf",
"pdcurses"
],
"vcpkg-configuration": {
"overlay-ports": [
"../.github/vcpkg_ports"
]
}
]
}
Loading