-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qualities to copy-from recipes in mods #78536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @LyleSY
probably uses default tools defined in forging_standard |
The solution description is a bit odd, as the first line seems to indicate the PR removes copy-from functionality, when it appears that it actually works around that deficiency. I'd probably change the first line to something like |
No issues from my end. I can confirm that anything I did in the mainline or in DinoMod was not intended to skip qualities |
thx, edited. English isn't my first language. |
Summary
None
Purpose of change
Many modded items (mostly XL/XS variants) are missing tool requirements.
closes #70884
Describe the solution
since copy-from doesn't copy qualities (see #60257 ), add them to the recipes.
check the mods folder for any recipes that copy from another, that do not have the qualities of parent.
Describe alternatives you've considered
make copy-from properly inherit, but I'm not into the c++ code yet.
Testing
Additional context
It is possible that some of those are intentional, but I find that unlikely and do not know how to distinguish them.