Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualities to copy-from recipes in mods #78536

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

marilynias
Copy link
Contributor

@marilynias marilynias commented Dec 13, 2024

Summary

None

Purpose of change

Many modded items (mostly XL/XS variants) are missing tool requirements.
closes #70884

Describe the solution

since copy-from doesn't copy qualities (see #60257 ), add them to the recipes.
check the mods folder for any recipes that copy from another, that do not have the qualities of parent.

Describe alternatives you've considered

make copy-from properly inherit, but I'm not into the c++ code yet.

Testing

Screenshot_20241213_164543
Screenshot_20241213_170848

Additional context

It is possible that some of those are intentional, but I find that unlikely and do not know how to distinguish them.

@marilynias marilynias marked this pull request as draft December 13, 2024 08:59
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 13, 2024
@GuardianDll
Copy link
Member

I found that "armor_cuirass" does not require any tools?

probably uses default tools defined in forging_standard

@marilynias marilynias marked this pull request as ready for review December 13, 2024 10:25
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 13, 2024
@PatrikLundell
Copy link
Contributor

The solution description is a bit odd, as the first line seems to indicate the PR removes copy-from functionality, when it appears that it actually works around that deficiency.

I'd probably change the first line to something like
"Since copy-from doesn't copy qualities (see #60257 ):"

@LyleSY
Copy link
Contributor

LyleSY commented Dec 13, 2024

No issues from my end. I can confirm that anything I did in the mainline or in DinoMod was not intended to skip qualities

@marilynias
Copy link
Contributor Author

The solution description is a bit odd, as the first line seems to indicate the PR removes copy-from functionality, when it appears that it actually works around that deficiency.

I'd probably change the first line to something like "Since copy-from doesn't copy qualities (see #60257 ):"

thx, edited. English isn't my first language.

@Procyonae
Copy link
Contributor

Making the copy-from work actually looks really easy, the only issue is it needs loads of stuff going through and doing the opposite of this PR otherwise it comes up with a bunch of errors bc it seems to be storing duplicates as individual entries

Change that appears to work
image

In game result
image

@Night-Pryanik Night-Pryanik merged commit 508e922 into CleverRaven:master Dec 14, 2024
24 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 14, 2024
@marilynias marilynias deleted the fix-inheritence branch December 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Magiclysm] XL demon chitin armor needs no tools
6 participants