Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm/Innawood] Add the giant trees as points of interest (sans druid base) #78534

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 13, 2024

Summary

Mods "[Magiclysm/Innawood] Add the giant trees as points of interest (sans druid base)"

Purpose of change

I made those giant trees and it's a shame that they don't spawn Innawood.

Describe the solution

Add special innawood spawns for the giant trees, but as just giant trees without any druid base inside.

Add a rare variant that does have rooms inside, carved out of the trunk by the tree's inhabitants? Maybe. KorGgentT asked me if the inhabitants were parasitic or symbiotic and it requires further thought, so this part will come later.

Describe alternatives you've considered

Testing

Trees spawn and have the appropriate appearance.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft December 13, 2024 04:08
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Magiclysm Anything to do with the Magiclysm mod labels Dec 13, 2024
@github-actions github-actions bot requested a review from KorGgenT December 13, 2024 04:09
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 13, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review December 15, 2024 02:33
@Night-Pryanik Night-Pryanik merged commit fc64fff into CleverRaven:master Dec 15, 2024
27 of 33 checks passed
@Standing-Storm Standing-Storm deleted the druid-tree-innawood branch December 16, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants