Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Give elves their own sight trait instead of using fey vision, slightly reduce their hearing. #78516

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 12, 2024

Summary

Mods "[Magiclysm] Give elves their own sight trait instead of using fey vision"

Purpose of change

When I first added the Magiclysm fantasy species, there was no way to give someone night vision except the hardcoded traits. But now we can use enchantments.

Describe the solution

Give elves the Elvensight trait, which provides 5 squares of night vision. Someday hopefully there will be a distinction between "No Light" and "Low Light' and I can greatly increase this but make it not work at all in total darkness, but until then, 5 squares will work.

I cut their hearing from 5.1 multiplier to 2 multiplier, since the way hearing works means you'll be constantly woken up by the tiniest sounds with such a high hearing level.

Also add the EYES type to this and the goblin Nocturnal Vision trait.

Describe alternatives you've considered

Testing

Elvensight shows up in character creation.

Additional context

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Magiclysm Anything to do with the Magiclysm mod labels Dec 12, 2024
@github-actions github-actions bot requested a review from KorGgenT December 12, 2024 17:45
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Elvensight

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 12, 2024
@Night-Pryanik Night-Pryanik merged commit 0b5cbb9 into CleverRaven:master Dec 13, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the elvensight branch December 13, 2024 06:41
@jeffnonumber

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants