Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm/Innawood] Revamp goblin/orc drops to separate itemgroups, make them fit Innawood #78503

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 11, 2024

Summary

Mods "[Magiclysm/Innawood] Revamp goblin/orc drops to separate itemgroups, make them fit Innawood"

Purpose of change

Loaded up a Magiclysm/Innawood game and noticed the goblin villages and realized that goblins might be dropping modern gear, and then realized there were other problems (like goblin armor and clothes dropping undamaged).

Describe the solution

Remove all the in-line death drops from goblins, orcs, and bugbears, make them separate itemgroups.

Make the itemgroups linked to sub-itemgroups like goblin_chieftan_weapon_drops

Add damage chance to these groups.

Override the armor Innawood so they have leather armor, not metal armor. Override their weapons so they're stone and bone and wood, not metal.

Describe alternatives you've considered

Testing

Spawned a goblin camp, killed everyone, checked the loot.

Went to innawood, spawned a goblin camp, killed everyone, made sure there were no talking dolls or floral blankets or anything.

Additional context

Now with fixed commit history

@Standing-Storm Standing-Storm marked this pull request as draft December 11, 2024 21:08
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Dec 11, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 12, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review December 12, 2024 03:01
@github-actions github-actions bot requested a review from KorGgenT December 12, 2024 03:02
@Night-Pryanik Night-Pryanik merged commit b871679 into CleverRaven:master Dec 12, 2024
25 of 28 checks passed
@Standing-Storm Standing-Storm deleted the goblin-bugbear-orc-death-drops branch December 12, 2024 06:47
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants