Deprecate ARMOR_, EXTRA_ and ITEM_ARMOR_ enchantments #78474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ITEM_ARMOR_ as not used
…into enchantment_stuff_again
github-actions
bot
added
<Documentation>
github-actions
bot
added
Bionics
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks @Standing-Storm
github-actions
bot
added
<Bugfix>
GuardianDll
force-pushed
the
enchantment_stuff_again
branch
from
f623637 to
48e6d46
Compare
emixa-d
reviewed
Dec 10, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
GuardianDll
force-pushed
the
enchantment_stuff_again
branch
from
2dcce1a to
8df5b80
Compare
github-actions
bot
added
the
BasicBuildPassed
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
hardcoded damage types is bad
Describe the solution
Refactor the enechantment code somewhat
Deprecate ARMOR_ and EXTRA_ enchantment in favor of
incoming_damage_modandincoming_damage_mod_post_absorbedfieldsDeprecate ITEM_ARMOR_ code without replacement, as nothing used it, and it was an awful piece
move some code to creature, for it is used by both characters and monsters
Should fix #72000
Testing
The game is compiled, few magiclysm traits are tested to confirm they work