Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Improve readability of skip clauses for matrix build" #78362

Closed
wants to merge 1 commit into from
Closed

Revert "Improve readability of skip clauses for matrix build" #78362

wants to merge 1 commit into from

Conversation

kevingranade
Copy link
Member

Reverts #78347

Summary

None

I'm not clear why but it looks like this broje the skip logic.

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 5, 2024
@akrieger
Copy link
Member

akrieger commented Dec 5, 2024 •
edited
Loading

https://github.com/AllanChain/test-action-if/blob/main/.github/workflows/test-if.yml#L31-L37 this is fixable. Use >- instead of > for the multiline.

https://stackoverflow.com/a/67532120

@kevingranade kevingranade mentioned this pull request Dec 5, 2024
Merged
@kevingranade kevingranade deleted the revert-78347-kevingranade-matrix-build-multiline-readability branch December 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevingranade @akrieger