Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to scores menu #78335

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fixes to scores menu #78335

merged 1 commit into from
Dec 5, 2024

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Dec 4, 2024 •
edited
Loading

Summary

Bugfixes "Fixes to scores menu"

Purpose of change

Fixes #78331 (hopefully)

Describe the solution

Various fixes to scores menu:

  • make window size bigger;
  • make menu faster (generate data only once before window is displayed, not during each tab change);
  • fix scrolling for Android;
  • reset scrolling position on tab switch;
  • allow HOME and END buttons to scroll to top and bottom of the tab;
  • allow toggling monster/npc groups in Kills tab;
  • cleaned up enum-related code.

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Dec 4, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Achievements / Conducts / Scores Player goals and how they are tracked. labels Dec 4, 2024
github-actions[bot]
github-actions bot reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Qrox

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Dec 4, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 4, 2024
@ZhilkinSerg ZhilkinSerg force-pushed the scoreui-fixes branch 2 times, most recently from 993a9c7 to 212b29f Compare December 4, 2024 13:49
@ZhilkinSerg ZhilkinSerg changed the title Fix scrolling in score menu Fixes to score menu Dec 4, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 4, 2024
@ZhilkinSerg ZhilkinSerg force-pushed the scoreui-fixes branch 2 times, most recently from b41613c to a671bd8 Compare December 4, 2024 22:21
@ZhilkinSerg ZhilkinSerg changed the title Fixes to score menu Fixes to scores menu Dec 4, 2024
@ZhilkinSerg ZhilkinSerg force-pushed the scoreui-fixes branch 2 times, most recently from 2ba3b85 to a8b488f Compare December 4, 2024 22:31
@ZhilkinSerg
Copy link
Contributor Author

@kevingranade I suspect something is wrong in either #78347 or #78348 because of how quickly CI checks are passing now:

image

@Night-Pryanik Night-Pryanik merged commit 943529c into CleverRaven:master Dec 5, 2024
25 of 28 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 5, 2024
@ZhilkinSerg ZhilkinSerg deleted the scoreui-fixes branch December 5, 2024 12:01
@kevingranade
Copy link
Member

Yea it was #78347 by way of a bizzare YAML/GHA interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot scroll the achievements, kills, and scores screen (on android)
3 participants
@ZhilkinSerg @kevingranade @Night-Pryanik