[MoM] Add new u_cancel_activity to unlocking new power/wakeful rest
#78292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
Comment on lines
+175
to
+176
| "u_cancel_activity", | ||
| "u_cancel_activity" |
There was a problem hiding this comment.
Double cancel_activity is intended?
Comment on lines
+182
to
+183
| "u_cancel_activity", | ||
| "u_cancel_activity" |
There was a problem hiding this comment.
Looks like those were manually added before I replaced all instances. I'll check if it causes a problem in game and, if not, clean it up at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Add new
u_cancel_activityto unlocking new power/wakeful rest"Purpose of change
MoM has had some weirdness requiring a popup to interrupt your activity so you can stop it at the right time because there was no
u_cancel_activity. But now there is.Fixes #75984
Describe the solution
Add
u_cancel_activityto the Wakeful Rest EoC and all the new power learning EoCs. Remove the popup from Wakeful Rest.Describe alternatives you've considered
Testing
Wakeful Rest now ends when appropriate with a simple message.
Activity properly ends when learning a new power no matter what you pick on the popup (Yes, No, or Ignore). This fixes the bug with infinite activity.
Additional context