Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug and summon_vehicle spell spawning ignore VEHICLE_STATUS_AT_SPAWN #78277

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

summon_spell was using status 0 instead of 2
summon_spell was spawning damaged vehicles if VEHICLE_STATUS_AT_SPAWN was set (eg No Hope was enabled)

Describe the solution

Adds a force bool that only affects debug spawning and summon_vehicle spell

Describe alternatives you've considered

Adding extra status numbers but our current ones are already kind of a mess.

Testing

image
Debug spawned a pristine vehicle with no security system and faults and cast Summon Mojocycle with the same results with both Magiclysm and No Hope enabled

Additional context

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 1, 2024
@github-actions github-actions bot requested a review from KorGgenT December 1, 2024 11:00
@github-actions github-actions bot added Mechanics: Enchantments / Spells Enchantments and spells astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 1, 2024
@Maleclypse
Copy link
Member

@Night-Pryanik tagging you since I'm not sure this is used anywhere outside of nohope and while I think it would be weird for magic to summon damaged vehicles I figured you should have a say in this.

@Night-Pryanik
Copy link
Contributor

I fully support this PR. Summoning vehicles should spawn them undamaged, even with NH. This external option should only affect mapgen-spawned vehicles.

@Maleclypse Maleclypse merged commit b0f3322 into CleverRaven:master Dec 4, 2024
20 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants