Add globally unique to more npc locations #78246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core-game version of CleverRaven#63627
Co-authored-by: Procyonae <[email protected]>
github-actions
bot
added
NPC / Factions
|
As part of the description/summary of the PR please list the locations made globally unique. I reviewed them and they looked good but I’d like to make sure |
|
Updated the description to include a list of changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Revives #66264
Describe the solution
Branched off linked pr, cleanud up a bit, looked over all instances of
OVERMAP_UNIQUEto see if anything was overlooked.List of changes:
Increased search range for exodii from their signpost and retrieve prospectus from Smokes to 540 instead of 400 and 200.
Added
GLOBALLY_UNIQUEto Lapins cabin, Alcatraz prison, the prison with a lab, biker dump, the Mi-Go portal, the occupied chem lab, the occupied scrap yard, occupied lumbermill, and the occupied homeless camp.Removed
OVERMAP_UNIQUEfrom Hub01 as they already are globally unique.Adjusted occurrences of locations made globally unique.
Describe alternatives you've considered
Testing
Ran a few tests locally, didn't get any failures.
Additional context