Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new exodii rifle #78163

Merged
merged 10 commits into from
Nov 29, 2024
Merged

new exodii rifle #78163

merged 10 commits into from
Nov 29, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Nov 26, 2024

Summary

Content "New exodii rifle"

Purpose of change

Something i wanted to add for a while

Describe the solution

Add a gun and surrounding infra

Testing

image
image
image
image
image

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 26, 2024
data/json/items/ammo/exodii.json Outdated Show resolved Hide resolved
data/json/items/ammo/exodii.json Outdated Show resolved Hide resolved
data/json/items/gunmod/underbarrel.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
GuardianDll and others added 2 commits November 26, 2024 10:19
data/json/items/ammo/exodii.json Outdated Show resolved Hide resolved
data/json/items/generic/casing.json Outdated Show resolved Hide resolved
data/json/items/gun/exodii.json Outdated Show resolved Hide resolved
data/json/items/gun/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
Co-authored-by: DSeyka <[email protected]>
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Nov 26, 2024
@PatrikLundell
Copy link
Contributor

PatrikLundell commented Nov 26, 2024

data/json/items/gun/exodii.json:

"Originally designed for naval defense of a small island country, this gun has served the Exodii for as long as they have existed, being one of their reliable tools in the later stages of world decay. Cheap ammunition, a simple mechanism, and immense power output would make it a great weapon for any survivor who is able to carry nearly a ??? of its weight and is in need of penetrating a small bunker. Unless your body is compatible with the Exodii Standard Combat Bodyframe, you can only use it with a heavy-duty tripod, and only while prone. Due to the size of the top-mounted magazine, the user has to use a scope mounted on the side of the gun."

I have no idea what a "centner" is supposed to be. The text is in English, so the units should be recognizable as well (and please don't try "stones", even if this nominally is English).

"description": "A bulky 4-round magazine for the Exodii Ree 3.3 rifle. Even this small capacity magazine is hard to handle for a human."

This original doesn't seem correct: Is the magazine really weighing "a hundredweight" (use English compatible measurements!), rather than the gun?

"description": "Giant metal box with a belt, which allows it to be used as a high-capacity magazine for the Exodii Ree 3.3 rifle.",

Edit: It seems something has gobbled up many of my marking of the changes...

@GuardianDll
Copy link
Member Author

GuardianDll commented Nov 26, 2024

I found no better word for "100 kg" than https://en.wikipedia.org/wiki/Quintal
In my (or, rather, Pryanik) defence, hundredweight is in fact british/US measurement, albeit unofficial

Is the magazine really weighing "a hundredweight"

description clearly says Grants some amount of portability, if a hundredweight piece of metal can be named portable, and piece of metal here is, of course, referring to the gun

@Knut-Aage-Hofseth
Copy link
Contributor

Is the descrition from the point of view of the survivor, or from the Exodii?

@GuardianDll
Copy link
Member Author

Exodii, same as the rest of exodii guns
Ideally such description should be moved elsewhere, and item description presenting it from survivor point of view, but it require some additional work, so i decided to follow the previous examples

@Knut-Aage-Hofseth
Copy link
Contributor

Exodii, same as the rest of exodii guns Ideally such description should be moved elsewhere, and item description presenting it from survivor point of view, but it require some additional work, so i decided to follow the previous examples

In that case I think that centner is a cool word to include given the strange word-choices the Exodii sometimes have.

@PatrikLundell
Copy link
Contributor

I don't see the point of having the description of a magazine refer to the weight of the weapon it's used with. That's out of scope.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 26, 2024
@ampersand55
Copy link
Contributor

We could describe the weight in tonnes or long tons if we want to be a bit fancy/naval but still having it being recognizable in English. E.g. "if a tenth tonne gun can be named portable" or "if a gun weighing a tenth of a long ton can be named portable".

The long ton was used to displacement of ships or a measure of bulk goods in shipping, and it would make sense for the unit to be used in describing something bulky in a naval context.

@github-actions github-actions bot added Items: Magazines Ammo holding items and objects. Mods: Generic Guns Anything to do with Generic Guns BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 27, 2024
data/json/items/gun/exodii.json Outdated Show resolved Hide resolved
data/json/items/gun/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/json/items/magazine/exodii.json Outdated Show resolved Hide resolved
data/mods/Generic_Guns/firearms/rifle.json Outdated Show resolved Hide resolved
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A bulky 4-round magazine for the Exodii Ree 3.3 rifle. Grants some amount of portability, if the gun itself can be named portable.
  • Bulky box magazine for exodii cannon rifle.
  • Giant metal box with a belt, which allows it to be used as a high-capacity magazine for the Exodii Ree 3.3 rifle.
  • Originally designed for naval defense of a small island country, this gun served Exodii as long as they existed, being one of its reliable tools in later stages of world decay. Cheap ammunition, a simple mechanism, and immense power output would make it a great weapon for any survivor who is able to carry nearly a hundred kilo of its weight and is in need to penetrate a small bunker. Unless your body is compatible with Exodii Standard Combat Bodyframe, you can only use it with a heavy-duty tripod, and only while prone. Due to the size of a top-mounted magazine, the user needs to use a scope mounted on the side of a gun.
  • Ree 3.3 exodii rifle
  • Small magazine for exodii cannon rifle.
  • exodii naval rifle
  • exodii naval rifles

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Night-Pryanik Night-Pryanik merged commit bff184b into CleverRaven:master Nov 29, 2024
21 of 27 checks passed
@GuardianDll GuardianDll deleted the ree_33 branch November 29, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants