Fix crashing in CURSES without ASCII title art #78103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix crashing in CURSES without ASCII title art"
Purpose of change
Testing PDcurses build on Windows via CMake. The
ENABLE_ASCII_TITLEoptions was crashing to desktop because of wrong logic.PATH_INFO::title()returned"Cataclysm: Dark Days Ahead", and the game was trying to open a file with that name in its part.Describe the solution
Check
ENABLE_ASCII_TITLEbefore.Describe alternatives you've considered
Change
PATH_INFO::title().Testing
Run Windows PDCurses build with and without
ENABLE_ASCII_TITLE.Additional context
N/A