Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a concrete carpet parametrized palette and apply it #78004

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

Milopetilo
Copy link
Contributor

Summary

None

Purpose of change

Turns out there's more than 1 type of carpet, so I should probably make a parametrized palette for the other type that is in use.

Describe the solution

Add the palette, make mapgen use the palette.

Describe alternatives you've considered

Add all the types of carpets but most other types are barely used and would probably just be bloat.

Testing

Game loads, carpets are different

Additional context

Wanted to also use it in palettes but doesn't work (#78003)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Items: Food / Vitamins Comestibles and drinks json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 19, 2024
@Maleclypse Maleclypse merged commit 98baf15 into CleverRaven:master Nov 23, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants