Don't release spores when destroyed by fire #77841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #77743, i.e. destruction of fungal terrain by fire triggers spore release.
Describe the solution
Add condition that whatever is "bashed" mustn't be on fire to be able to release spores (either the spores are long since consumed by the fire, or they catch fire and are destroyed on release).
Describe alternatives you've considered
Convoluted passing of a parameter down the call chain to say that "bashing" shouldn't cause fungal spores to be released (because destruction of the thing was caused by fire, so there are no undamaged spores left to release).
Testing
Additional context
The implementation should mean that if you set fungal stuff on fire before bashing them they won't release spores, even though your bashing may beat the fire to the destruction. I think that case is too niche to be worth the trouble to make sure destruction is actually by fire.