Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't release spores when destroyed by fire #77841

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #77743, i.e. destruction of fungal terrain by fire triggers spore release.

Describe the solution

Add condition that whatever is "bashed" mustn't be on fire to be able to release spores (either the spores are long since consumed by the fire, or they catch fire and are destroyed on release).

Describe alternatives you've considered

Convoluted passing of a parameter down the call chain to say that "bashing" shouldn't cause fungal spores to be released (because destruction of the thing was caused by fire, so there are no undamaged spores left to release).

Testing

  • Loaded a save.
  • Teleported to a fungal tower.
  • Debug killed the critters around to be able to work in peace.
  • Debug spawned a sledge hammer and STR to 200.
  • Bashed fungal patch until it was destroyed and released spores.
  • Set fire to a fungal patch and the fungal tower area.
  • Waited.
  • Saw the fire spread and the fungal stuff burned, without lots of spore spreading.

Additional context

The implementation should mean that if you set fungal stuff on fire before bashing them they won't release spores, even though your bashing may beat the fire to the destruction. I think that case is too niche to be worth the trouble to make sure destruction is actually by fire.

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 14, 2024
@Maleclypse Maleclypse merged commit 60c66b0 into CleverRaven:master Nov 15, 2024
21 of 28 checks passed
@PatrikLundell PatrikLundell deleted the fire_spore branch November 15, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fire makes fungus spread faster
2 participants