Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Update proficiency families and weakpoints for Magiclysm monsters #77766

Merged

Conversation

jpfalk1
Copy link
Contributor

@jpfalk1 jpfalk1 commented Nov 11, 2024

Summary

Mods "Reviewed Magiclysm Monsters and added proficiency families and weakpoints when missing."

Purpose of change

Two related issues noted missing proficiencies and weakpoints in Magiclysm monsters. Resolves #70307, resolves #77361. Black Dragons deserve a custom set of weakpoints, so will be addressed with a separate PR.

Describe the solution

Added existing applicable proficiency families (mostly "prof_gross_anatomy", "prof_intro_biology", and "prof_physiology") and weakpoints (mostly "wps_humanoid_body", and "wps_animal_quadruped") to Magiclysm monsters. Using existing proficiency and weakpoint sets from similar base CDDA monsters (i.e. Owlbear has similar proficiencies and weakpoints as a Bear, since it doesn't fly)
Demon Spiders also received applicable bug/spider proficiencies and weakpoints. Some of their general data was also moved to the mod-wide file that was appropriate (i.e. Demon Spider species data moved to data/mods/Magiclysm/species.json). An abstract monster type for demon spiders was also created, although this may have been unnecessary complexity.
Demihuman monsters were updated to consistently include "prof_gross_anatomy" and "prof_intro_biology". Most already had weakpoints defined and the "demihuman" proficiency.
Black Dragons deserve their own unique weakpoints and proficiencies so will be addressed with a separate PR as this one only used existing proficiencies and weakpoints.
Spirits, holograms, summons, and other related monsters that don't leave a corpse or were primarily intended as player summons were left undefined.
Golems were left undefined for proficiencies / weakpoints, consistent with robots in base CDDA.

Describe alternatives you've considered

Considered a new set of proficiencies for all Magiclysm monsters (i.e. "Magical Creature") but this seemed overkill for the majority of the creatures so existing proficiencies were used instead (again, except Black Dragons).
Considered leaving undefined, treating Magiclysm monsters are "too different" to have weakpoints. A lot of the demi-human monsters already had proficiencies/weakpoints defined, it was the odd creatures like Yule Cats and such that did not.

Testing

Created a local mod and spawned a sampling of affected monsters to confirm dissection provided the relevant proficiency training. Did not have a good consistent test to assess weakpoints, or appropriateness of selected weakpoints.

Additional context

Added weakpoints to monsters that were missing them in Magiclysm mod. Added monster abstracts when possible to make future updates / changes easier should Magiclysm specific weakpoints be created.
Addressing issue CleverRaven#70307 and related.
Move monster faction and species information for demon spiders to the dedicated JSON files instead of the monster file.
Not all demihumans were getting the into_biology and gross_anatomy families.
Ogres, Orcs, and Goblins all get intro_biology and gross_anatomy. Just like Elves, Dwarves, and Ravenfolk.
Workshop Elves, and Leprechauns get intro_bio and gross_anatomy.
Both Monsters and Zombified versions get weakpoints and families.
Fixing naming, syntax, and other errors from testing on local CDDA install.
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod labels Nov 11, 2024
@github-actions github-actions bot requested a review from KorGgenT November 11, 2024 21:09
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • abstract demon spider. you should't see this

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 11, 2024
jpfalk1 and others added 14 commits November 11, 2024 16:07
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Typo correction suggested by bot
@jpfalk1
Copy link
Contributor Author

jpfalk1 commented Nov 12, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Fixed.

In general did not do as good a job as I thought in setting up the editor to match the JSON style guide. Will be sure to use the linter in the future.

jpfalk1 and others added 12 commits November 11, 2024 16:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 12, 2024
Remove "." from description string which threw error in automated testing.
@jpfalk1
Copy link
Contributor Author

jpfalk1 commented Nov 12, 2024

Basic build didn't like the "." in the abstract description. Removed.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 13, 2024
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
jpfalk1 and others added 3 commits November 13, 2024 09:02
Removed "demihuman" family for loup_garou as suggested. Also changed weakpoint set to "quadruped" from "humanoid".
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 13, 2024
@jpfalk1 jpfalk1 requested a review from Maleclypse November 16, 2024 00:38
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 18, 2024
@Night-Pryanik Night-Pryanik merged commit 1ca5828 into CleverRaven:master Nov 18, 2024
18 of 24 checks passed
@jpfalk1 jpfalk1 deleted the audit_magiclysm_monster_dissection branch November 19, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
3 participants