-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Update proficiency families and weakpoints for Magiclysm monsters #77766
[Magiclysm] Update proficiency families and weakpoints for Magiclysm monsters #77766
Conversation
Added weakpoints to monsters that were missing them in Magiclysm mod. Added monster abstracts when possible to make future updates / changes easier should Magiclysm specific weakpoints be created. Addressing issue CleverRaven#70307 and related.
Move monster faction and species information for demon spiders to the dedicated JSON files instead of the monster file.
Not all demihumans were getting the into_biology and gross_anatomy families.
Ogres, Orcs, and Goblins all get intro_biology and gross_anatomy. Just like Elves, Dwarves, and Ravenfolk.
Workshop Elves, and Leprechauns get intro_bio and gross_anatomy.
Both Monsters and Zombified versions get weakpoints and families.
Fixing naming, syntax, and other errors from testing on local CDDA install.
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Typo correction suggested by bot
Fixed. In general did not do as good a job as I thought in setting up the editor to match the JSON style guide. Will be sure to use the linter in the future. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Remove "." from description string which threw error in automated testing.
Basic build didn't like the "." in the abstract description. Removed. |
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: Maleclypse <[email protected]>
Co-authored-by: Maleclypse <[email protected]>
Removed "demihuman" family for loup_garou as suggested. Also changed weakpoint set to "quadruped" from "humanoid".
Summary
Mods "Reviewed Magiclysm Monsters and added proficiency families and weakpoints when missing."
Purpose of change
Two related issues noted missing proficiencies and weakpoints in Magiclysm monsters. Resolves #70307, resolves #77361. Black Dragons deserve a custom set of weakpoints, so will be addressed with a separate PR.
Describe the solution
Added existing applicable proficiency families (mostly "prof_gross_anatomy", "prof_intro_biology", and "prof_physiology") and weakpoints (mostly "wps_humanoid_body", and "wps_animal_quadruped") to Magiclysm monsters. Using existing proficiency and weakpoint sets from similar base CDDA monsters (i.e. Owlbear has similar proficiencies and weakpoints as a Bear, since it doesn't fly)
Demon Spiders also received applicable bug/spider proficiencies and weakpoints. Some of their general data was also moved to the mod-wide file that was appropriate (i.e. Demon Spider species data moved to data/mods/Magiclysm/species.json). An abstract monster type for demon spiders was also created, although this may have been unnecessary complexity.
Demihuman monsters were updated to consistently include "prof_gross_anatomy" and "prof_intro_biology". Most already had weakpoints defined and the "demihuman" proficiency.
Black Dragons deserve their own unique weakpoints and proficiencies so will be addressed with a separate PR as this one only used existing proficiencies and weakpoints.
Spirits, holograms, summons, and other related monsters that don't leave a corpse or were primarily intended as player summons were left undefined.
Golems were left undefined for proficiencies / weakpoints, consistent with robots in base CDDA.
Describe alternatives you've considered
Considered a new set of proficiencies for all Magiclysm monsters (i.e. "Magical Creature") but this seemed overkill for the majority of the creatures so existing proficiencies were used instead (again, except Black Dragons).
Considered leaving undefined, treating Magiclysm monsters are "too different" to have weakpoints. A lot of the demi-human monsters already had proficiencies/weakpoints defined, it was the odd creatures like Yule Cats and such that did not.
Testing
Created a local mod and spawned a sampling of affected monsters to confirm dissection provided the relevant proficiency training. Did not have a good consistent test to assess weakpoints, or appropriateness of selected weakpoints.
Additional context