Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using vines to descend no longer produces grappling hooks #77758

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

Kamejeir
Copy link
Contributor

@Kamejeir Kamejeir commented Nov 11, 2024

Summary

None

Purpose of change

buggy behavior

Describe the solution

add flags to mutations, check for said mutation on the thing where stair go down but no stair up

Describe alternatives you've considered

Testing

I now see a "Vine leading up"

Additional context

You can't actually redeploy vines, so technically a nerf

Also normal long ropes still transmute into grappling hooks via using them to descend stairs, but that's outside of what I intend to fix here.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Nov 11, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 11, 2024
@Kamejeir Kamejeir marked this pull request as draft November 11, 2024 14:52
@Kamejeir
Copy link
Contributor Author

Kamejeir commented Nov 11, 2024

Testing was insufficient, I have some more work to do. Testing was sufficient. I just didn't realize that Web Diver required activation.

@Kamejeir Kamejeir marked this pull request as ready for review November 11, 2024 14:56
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 11, 2024
@Maleclypse Maleclypse merged commit 6e7f4ff into CleverRaven:master Nov 11, 2024
21 of 27 checks passed
@Kamejeir Kamejeir deleted the VINE_RAPPEL branch November 11, 2024 20:40
@EvanBalster
Copy link
Contributor

As I recall from my work on climbing aids, the deployed grappling hook is currently represented by a "long rope" furniture which is displayed as a grappling hook. These two ought to be properly disentangled from one another but the migration might be messy. Be sure to visit the climbing aids JSON file if you look into this; definitions there control what furniture gets deployed when descending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants