Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Feral Soldier Drops #77737

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

DukePaulAtreid3s
Copy link
Contributor

Summary

Bugfixes "Corrects issue where Feral Soldiers' gear was more damaged than the Zombies"

Purpose of change

It makes very little sense for the Still-living version of a soldier to have trashed their gear more than a (most likely bullet ridden) shambling corpse.

Describe the solution

Revert most of the changes in #55139 , as the lootgroups that zombie soldiers use now are sufficient, also adds a lootgroup that guarantees they will have a knife. Finally, fixes the broken damage numbers that caused the original bug.

Describe alternatives you've considered

Testing

Additional context

I went through 6 nested itemgroups to confirm that this would function as planned.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 10, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 11, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 11, 2024
@Night-Pryanik Night-Pryanik merged commit 3d12651 into CleverRaven:master Nov 13, 2024
34 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants