-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash start rework #77541
Merged
Merged
crash start rework #77541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reminds me of #69746 which I'd like to revive at some point to make the crash start more realistic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Scenarios
New Scenarios, balancing, bugs with scenarios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "crash start rework"
Purpose of change
Fix #54731
Describe the solution
Creates new mx_mayhem with less variation just for this start
Changes the scenario to call that
Add ZONE_START_POINT to the specific mx_mayhem variant being called pinpointing the driver's seat
Describe alternatives you've considered
Change the road mapgen file to add a spawn zone. That broke many things.
Create a new map special.
Try using road_curved instead of road
Testing
Game loads no errors. Character appears in the crash in the driver's seat, hurt. Still spawns in the city, but at least it works.
![Screenshot 2024-11-02 at 8 01 10 PM](https://private-user-images.githubusercontent.com/26608431/382514717-9b303a66-557d-446b-ab76-b18c64af580e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNDIxMTYsIm5iZiI6MTczOTE0MTgxNiwicGF0aCI6Ii8yNjYwODQzMS8zODI1MTQ3MTctOWIzMDNhNjYtNTU3ZC00NDZiLWFiNzYtYjE4YzY0YWY1ODBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIyNTY1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4Y2I5NzUwNjkyMmUxYTg3MjlmZTU5MjA0MWZjNGYyMmY5NzcyZTI3NDhmYjBhYWFjNGMzMDE3OTVmZjJkYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.e9xi2C3AO1xaJA4pUd2UKGFJtHis_JHX7TcD5IRc080)
Additional context
"The car crash is a fertilizing rather than a destructive event." -Crash (1996)