Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash start rework #77541

Merged
merged 12 commits into from
Nov 13, 2024
Merged

crash start rework #77541

merged 12 commits into from
Nov 13, 2024

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Nov 2, 2024

Summary

Bugfixes "crash start rework"

Purpose of change

Fix #54731

Describe the solution

Creates new mx_mayhem with less variation just for this start
Changes the scenario to call that
Add ZONE_START_POINT to the specific mx_mayhem variant being called pinpointing the driver's seat

Describe alternatives you've considered

Change the road mapgen file to add a spawn zone. That broke many things.
Create a new map special.
Try using road_curved instead of road

Testing

Game loads no errors. Character appears in the crash in the driver's seat, hurt. Still spawns in the city, but at least it works.
Screenshot 2024-11-02 at 8 01 10 PM

Additional context

"The car crash is a fertilizing rather than a destructive event." -Crash (1996)

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Scenarios New Scenarios, balancing, bugs with scenarios astyled astyled PR, label is assigned by github actions labels Nov 2, 2024
@LyleSY LyleSY marked this pull request as ready for review November 3, 2024 00:05
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 3, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 4, 2024
@sparr
Copy link
Member

sparr commented Nov 4, 2024

This reminds me of #69746 which I'd like to revive at some point to make the crash start more realistic.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 11, 2024
@Night-Pryanik Night-Pryanik merged commit d6c225e into CleverRaven:master Nov 13, 2024
18 of 24 checks passed
@LyleSY LyleSY deleted the crash_start_rework branch November 13, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Car crash" scenario started in a house, with no cars.
3 participants