[XE] fix two bugs about learning new blood gifts #77533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[XE] fix two bugs about learning new blood gifts"
Purpose of change
Fix two bugs related to learning new blood gifts in XEDRA Evolved:
Being able to gain tier 5 powers without being a tier 5 vampire, fixing #77076.
The EoC not trying to give you powers of a lesser tier if you already have all the powers from the tier you rolled due to how it handles effect removal.
I also removed the outdated comments about the tier 4 and 5 effects being unobtainable, which isn't the case anymore.
Describe the solution
Modify the gift learning EoC to fix the aforementioned bugs
Describe alternatives you've considered
Not fixing bugs.
Testing
Set the character's intelligence to 100 so the EoC would always pick the highest tier.
Tried to get a power without having tier 5: I get told that I can't get tier 5 powers yet and obtain a tier 4 power instead.
Tried to get a power while having tier 5: I get a tier 5 power.
Tried to get a power while having all tier 5 powers: I get a tier 4 power.
Additional context
None yet