-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alarmed houses #77488
Add alarmed houses #77488
Conversation
i don't see the reason to draft it, the flag not working right now is not at all a reason to not merge mapgen edits upd: i fixed it nevertheless, in #77493, so i undraft it |
would the home security systems still function after being out of power for weeks (possibly months)? |
I would expect alarm systems to have batteries so the old trick of cutting phone and power lines before the "attack" won't work (the former is probably dealt with by cell connection nowadays anyway). The question would then be how long the batteries last, and I'd guess they run out fairly quickly, so half a year or so on a good year. It can also be noted that houses at least used to randomly have alarms. Has that been removed? |
The alarms that houses used to have were handled by the palette I'm changing. All this should change is make it so if one door has an alarm, the others will as well. |
> how long the batteries last |
I didn't really mean how long batteries last when the alarm is activated (although that's an issue that ought to be addressed eventually, but not in this PR), but how long they'd last when active. It seems nowadays more or less everything leaks electricity when "turned off", as opposed to the old days when you actually broke the circuit when turning off things, rather than slowly leaking on "standby". |
Quick searching seems to say home system batteries tend to only last 24 hours https://www.reddit.com/r/homesecurity/comments/17ajs9u/home_security_system_that_works_without_power_and/ |
I suspect the duration depends on what kind of a system it is. 24 hours sounds like it would be an active system with a fair bit of surveillance having a battery backup. I've rented a house with a system for the front door, and it had to be recharged every month, I think (or was it week? I don't remember, as it was a couple of decades ago). |
I guess it depends on what the battery is operating. The individual sensors might last a while, but the central system the sensors report to, maybe not. But IDK. My point is more that it's not obvious to me that this is actually a given. |
After some googling I can see that most alarm panels will last anywhere between 12-48 hrs without power, but the individual sensors would last for years. An alternative that could be implemented is only having alarms spawn if the roof spawns with solar panels, but that would require messing about with parameters and changing all roofs to use them, something I would like to avoid. |
Summary
Content "Houses sometimes have alarms"
Purpose of change
Some houses should have alarms, just like they do in real life.
Describe the solution
Add a palette param to
domestic_general_and_variant_palette
so houses that have alarms spawn with alarmed doors and windows.Describe alternatives you've considered
Only have alarmed doors since there is only one kind of alarmed window which seems to be used for shops, might follow up on this PR with one that adds more kinds of alarmed windows
Testing
Game loads, houses spawn alarmed, alarms don't work :(
Additional context
Draft until #72405 gets fixed