-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR] Pathfinding accounts for SMALL_PASSAGE #77446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
[C++]
Changes (can be) made in C++. Previously named `Code`
<Bugfix>
This is a fix for a bug (or closes open issue)
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 30, 2024
|
harakka
force-pushed
the
v_lorge_paths
branch
from
November 3, 2024 07:34
4f54fbf
to
23bab5b
Compare
2 tasks
harakka
changed the title
Pathfinding accounts for SMALL_PASSAGE
[CR] Pathfinding accounts for SMALL_PASSAGE
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
json-styled
JSON lint passed, label assigned by github actions
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Pathfinding accounts for SMALL_PASSAGE"
Purpose of change
Fixes #77385
Describe the solution
I added the check for openable but impassable terrain as its own if block instead of trying to integrate it into the already existing one below it for sake of readability.
TODO before undrafting
Describe alternatives you've considered
Testing
Tested with repro save from #77385:
0. Load repro save
1 .
O
->Sort out my loot (static zones only)
2. Observe that character will not try to open windows or pass through window frames
3. Load save again
4. Debug edit away the "Incoveniently large" mutation
5. Observe that character now paths through window frames and opens windows from the inside while looting progresses
Additional context
Draft for 0.H version of the fix #77550