Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secret science/military stuff from bank/industry/mall vaults #77155

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

harakka
Copy link
Member

@harakka harakka commented Oct 19, 2024

Summary

Content "Remove secret science and military stuff from bank/industry/mall vaults"

Purpose of change

Currently bank and light industry vaults have a chance to spawn a bunch of stuff related to secret science/military things that people doing secret science/military stuff would have zero reason to keep in some random bank safety deposit or light industry backroom safe. This removes those.

Describe the solution

Remove Rivtech design binder, classified chemical reference, robot schematics, and nanofab templates from bank vaults.

As extra bonus, also remove survivor notes, since there's zero reason why people's post-apocalyptic scribblings would be deposited in a bank vault.

Describe alternatives you've considered

Testing

Additional context

@harakka harakka force-pushed the less_vault_nonsense branch from 5ca2eb8 to 5ba95a8 Compare October 19, 2024 09:04
@harakka harakka changed the title Remove secret science stuff from bank/industry/mall vaults Remove secret science/military stuff from bank/industry/mall vaults Oct 19, 2024
@SirPendrak
Copy link
Contributor

HUB01 bar encounter merc NPC can sell nanofab templates. He mentions getting them from bank runs. From where does he gets them now?

@Kamejeir
Copy link
Contributor

Kamejeir commented Oct 19, 2024

HUB01 bar encounter merc NPC can sell nanofab templates. He mentions getting them from bank runs. From where does he gets them now?

here, harakka, the file in question. delete I guess?
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/npcs/robofac/robofac_ancilla_npcs/BAR_ENCOUNTER_MERCENARIES/BEM_template_seller.json

@SirPendrak
Copy link
Contributor

Wouldnt it be better to change word "bank" to "lab", instead of removing more features?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels Oct 19, 2024
@harakka
Copy link
Member Author

harakka commented Oct 19, 2024

Wouldnt it be better to change word "bank" to "lab"

Done

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 19, 2024
@RenechCDDA
Copy link
Member

Wouldnt it be better to change word "bank" to "lab", instead of removing more features?

A random piece of dialogue is not a "feature" in any way, and removing things that don't fit is important.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 20, 2024
@Maleclypse Maleclypse merged commit 8dfcebb into CleverRaven:master Oct 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants