Backport fix to not being able to put smaller mags into tac vest

[phelieros]

Summary

Bugfixes "Not being able to put smaller mags into tac vest"

Purpose of change

Fix #64815

Tac vest doesn't accept small mags when you try to insert them, providing a very confusing message as an explanation:

Describe the solution

Remove min_item_volume entries to make tac vest behave the same as other similar items, for example leg ammo pouch.
Here's a screen of attempting to insert the same mags into leg ammo pouch:

Describe alternatives you've considered

Testing

After removing the entries all mags within acceptable size limits can be put into tac vest:

Additional context

[AudBobb]

I imagine the original thought process here was a vest that didn't have actual 'pouches' for the magazines, but elastic straps, where in theory, the straps might not hold a small enough item securely. Something akin to the orange magazine on this.

However, I could not find a single actual tactical vest with a similar mechanism, so probably safe to assume that variety would be the exception

Would be interesting if we could apply a move cost penalty to drawing items with significantly smaller size than their holster to simulate having to fish around in the magazine pocket for your tiny ass magazine :P

[Kantonine]

I imagine the original thought process here was a vest that didn't have actual 'pouches' for the magazines, but elastic straps, where in theory, the straps might not hold a small enough item securely.

Thing is, is that the tac vest is actually pretty inaccurate to mags ingame now, due to a recent resizing for many magazines, the Tac vest ingame is modeled off of the Miltech USMC Vest:

The pockets of which are pretty form specific, compared to right now where it:

1. Allows BULKY DRUM MAGS!!!!
2. The pocket volume is also wayyyy too large, with 2 1L pockets (presumably rifle mags), while the irl version has three seperate pockets, and the 3 pistol mag pockets being 10x more spacious than they should

[AudBobb]

So if I'm looking at that vest correctly, top right is three pistol mags, bottom left is three standard rifle mags (hard to tell from the angle, but the one farthest from the camera maybe a tad larger?), bottom right is a pistol holster, and top left is a small utility pouch?

And yeah, nothing on that vest looks anywhere close to 1L lol. It would at best hold maybe a STANAG 30rd in the bottom left pockets

Edit: looked up another pic of the vest, and it's interesting to note that the holster is actually a MOLLE attachment?

[Kantonine]

So if I'm looking at that vest correctly, top right is three pistol mags, bottom left is three standard rifle mags (hard to tell from the angle, but the one farthest from the camera maybe a tad larger?), bottom right is a pistol holster, and top left is a small utility pouch?

And yeah, nothing on that vest looks anywhere close to 1L lol. It would at best hold maybe a STANAG 30rd in the bottom left pockets

Edit: looked up another pic of the vest, and it's interesting to note that the holster is actually a MOLLE attachment?

Yeah, 3 stanag mags, 3 pistol mags, universal pistol holder, and the pouch on the upper left above the rifle mag pouches is a shot shell pouch in game, tho it seems to be just a general use one irl.

[AudBobb]

I actually found that same listing and have a list of changes ready to implement once this PR get's merged to bring the vest more in line with the real model.

As for the shot shells, PR #51750 has a picture of the vest with a Velcro shot shell holder that goes on that top left pouch. That also seems to be where most of the pockets that the vest has were implemented, although for some reason that top left pocket, the two interior pockets, and the hydration pouch pocket were neglected.

[GuardianDll]

You would need to commit it to the experimental branch also, this one limit the fix only to 0.H branch

[phelieros]

You would need to commit it to the experimental branch also, this one limit the fix only to 0.H branch

I've checked master branch and apparently it was already done in #71099 as part of magazine audit.

Since it wasn't backported I suggest to merge this PR as an immediate fix to the bug demonstrated in original post and then @AudBobb may be interested in taking a look at the changes in said magazine audit PR to work on changes to tac vest he has in mind.