Fixed issue where extra cursor was drawn in ImGui InputText field on TUI builds erroneously #77089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes issue where the last typed character in an ImGui InputText field is covered by blank space on TUI/curses build"
Purpose of change
Fixes: #76129
Describe the solution
The IME Pre-Edit Text PR caused a regression on TUI/curses where some extra blank space is drawn on the screen. This was because of a typo where we were comparing a pointer on the stack to NULL, which will never be true. This instead checks if the first item in the array is NULL, this implies an empty string.
Describe alternatives you've considered
could have used ifdef TUI to block out pre-edit code entirely since none of it applies to curses, this just seemed simpler.
Testing
Before:
After:
Additional context