Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Check for beta talker on damage EoCs #77087

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Oct 16, 2024

Summary

Bugfixes "[MoM] Check for beta talker on damage EoCs"

Purpose of change

The monster_takes_damage EoCs also trigger if the monster suffers damage with no source (like the unviable portal life forms). If the damage has no source, they have no attacker, and the EoC checking the attacker for conditions fails to find anything, causing a talker error.

Fixes #77085

Describe the solution

Make the first condition has_beta and only check effects on the beta talker if there is a beta talker to check effects on.

Describe alternatives you've considered

Testing

Cannot load the provided save, but spawned in an alien meadow and waited for 20 hours while veiled butterflies flew around. No crashes.

Additional context

Sukkot starts tonight at sundown straight into Shabbat so it's going to be a few days until I can make sure this actually works.

@Standing-Storm Standing-Storm marked this pull request as draft October 16, 2024 14:11
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Oct 16, 2024
Standing-Storm and others added 2 commits October 16, 2024 09:14
…ents.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ents.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Oct 16, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 16, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review October 16, 2024 22:01
@Maleclypse Maleclypse merged commit 413c736 into CleverRaven:master Oct 17, 2024
34 of 40 checks passed
@Standing-Storm Standing-Storm deleted the Standing-Storm-patch-1 branch October 20, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talking and Mom related bug
2 participants