Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A properly GUI menu for editing npctalkvar #77055

Merged

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

I open edit var menu

It asks me for a variable name

I don't have the variable name memorized, and my old hands are prone to typos. There is no way to know if I get the name right, either. This is awful.

Describe the solution

Make a proper uilist for it

Describe alternatives you've considered

Chaos! Arson!

Testing

image

image-1

Additional context

src/debug_menu.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Oct 14, 2024
@RenechCDDA RenechCDDA force-pushed the debug_menu_edit_npctalkvar branch 2 times, most recently from 7e6f43b to afdf51f Compare October 14, 2024 23:50
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Add new npctalkvar (global)
  • Add new npctalkvar (local)
  • Edit npctalkvar variables (%s)
  • Edit npctalkvar variables (global)

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 15, 2024
@RenechCDDA RenechCDDA force-pushed the debug_menu_edit_npctalkvar branch from afdf51f to 0b781a1 Compare October 16, 2024 00:02
@Maleclypse
Copy link
Member

This looks good to go but there is an unresolved conversation. Is that still ongoing?

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 27, 2024
@Maleclypse Maleclypse merged commit 60cb55f into CleverRaven:master Nov 1, 2024
20 of 26 checks passed
@RenechCDDA RenechCDDA deleted the debug_menu_edit_npctalkvar branch November 1, 2024 04:40
GuardianDll added a commit to GuardianDll/Cataclysm-DDA that referenced this pull request Nov 1, 2024
Maleclypse pushed a commit that referenced this pull request Nov 17, 2024
* get rid of npctalk_var_ prefix for eoc variables

* cleanup after #77055

* deprecate more of type and context

* migrate item vars, make migration happen only once

* doc updates

* migrate u/npc/monster variables

* fix context var migration

* remove `substr( 12 )` in math parser

* move migration to a single function where possible

* no auto

* please clang

* Please clang more

* fix submap load test

* clean up after #77656

* cleanups after #77520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants