-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A properly GUI menu for editing npctalkvar #77055
A properly GUI menu for editing npctalkvar #77055
Conversation
7e6f43b
to
afdf51f
Compare
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
afdf51f
to
0b781a1
Compare
This looks good to go but there is an unresolved conversation. Is that still ongoing? |
* get rid of npctalk_var_ prefix for eoc variables * cleanup after #77055 * deprecate more of type and context * migrate item vars, make migration happen only once * doc updates * migrate u/npc/monster variables * fix context var migration * remove `substr( 12 )` in math parser * move migration to a single function where possible * no auto * please clang * Please clang more * fix submap load test * clean up after #77656 * cleanups after #77520
Summary
None
Purpose of change
I open edit var menu
It asks me for a variable name
I don't have the variable name memorized, and my old hands are prone to typos. There is no way to know if I get the name right, either. This is awful.
Describe the solution
Make a proper uilist for it
Describe alternatives you've considered
Chaos! Arson!
Testing
Additional context