-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some Britishisms in the JSON files. #76981
Fix some Britishisms in the JSON files. #76981
Conversation
This comes up on occasion, please only fix player visible British spellings. Anything with // or in other comment methods is to stay as is. |
801f72d
to
9f59843
Compare
Aight, should be fixed. |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Summary
Bugfixes "Fix Britishisms in the JSON files."
Purpose of change
In penance for being a bit annoying on the IRC, somebody requested that I do a review for britishisms.
Describe the solution
Instead of reviewing thousands of lines manually, I got AI Claude 3.5 Sonnet to make me a tool that basically just scans through all given files word-by-word and flags (and, if requested, substitutes) words that are in the British (
en_UK
) but not American (en_US
)system dictionary.Describe alternatives you've considered
Testing
Afterwards I did a manual review using
git diff --word-diff=color
, and consulted Merriam-Webster where unsure. Unless I've missed something, all words replaced at least list as "less common" on https://www.merriam-webster.com/ .Additional context
Should I do
src
too? It's a bit riskier cause of autoserialization.Also, should "arse" be dropped from the list of generic insults?
edit: An
"id"
change crept past me. I've grepped the diff; no"id"
changes aside from that one.