move volume and weight vals to math #76968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Since #76892 allow to use math evaluation on items, that means we can just add math function that allow us to directly check whatever we need, in all possible ways
Describe the solution
This PR replaces old
u_val('weight')
andu_val('volume')
with math syntax, that allow to be used on items. For volume it also adds abiltiy to read character volumeTesting
test json
Additional context
i would really like to also add the field similar to
time()
funciton, but #70996 uses some magic i am not familiar with