Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Dreamforged Nail #76952

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

gettingusedto
Copy link
Contributor

Summary

Mods "Adds dreamforged nail as one of the things dreamsmith can dream smith."

Purpose of change

I imagine dreamsmith can dream smiths themselves some dreamforged nail they can use on non-dreamsmithing crafts and constructions, so i add it.

Describe the solution

Adds dreamforged nails.

Describe alternatives you've considered

Not filling the spare part niche dreamsmith can fill.

Testing

I put it in as a mod and do the following:

  1. Checking the dreamforged nail recipe and craft it. It gives me 100 dreamforged nails as expected.
    Screenshot_20241011_022705_1

  2. Examine the item to see that it is infact dreamforged nail and checking that i dont forgot to rename it when i was copy pasting some other dreamforged item json.
    Screenshot_20241011_022738_1

  3. Check other crafting and construction recipe that uses nails and see the dreamforged nail in the list of nails.
    Screenshot_20241011_022830_1
    Screenshot_20241011_025130

Additional context

Maybe i should add dreamforged nuts and bolts next after this. Atleast i have something to work with.

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mods: Xedra Evolved Anything to do with Xedra Evolved labels Oct 10, 2024
@github-actions github-actions bot requested a review from Maleclypse October 10, 2024 20:12
gettingusedto and others added 2 commits October 11, 2024 03:22
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 10, 2024
@Maleclypse Maleclypse merged commit 405e875 into CleverRaven:master Oct 11, 2024
24 checks passed
@gettingusedto gettingusedto deleted the dreamforged_nail branch October 12, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants