No longer able to wear already worn items #76879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
Items / Item Actions / Item Qualities
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "No longer able to wear already worn items"
Purpose of change
If you open examine menu of already worn item and select
Wear(or pressW), you will try to wear it again, spending time and seeingYou put on your <item>despite nothing actually happens.I think that #45290 made this stuff work wrong.
Describe the solution
Made declaration of
to_wearreference inCharacter::wear.Describe alternatives you've considered
None.
Testing
Opened examination menu of already worn T-shirt, tried to wear it again. Got
You are already wearing that.message, and no time was spent.Also just in case tried to wear someone else's items (with stealing check), tried to wear items not already worn, tried to wear wielded items, tried to wear items on the ground, tried to wear items with open
Pickupmenu. No errors, items were worn as they should.Additional context
My understanding of all this reference and pointer stuff is very superficial, so I may be very wrong on proposed solution.