Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chilis smokable #76851

Conversation

AudBobb
Copy link
Contributor

@AudBobb AudBobb commented Oct 6, 2024

Summary

Features "Make chilis smokable"

Purpose of change

To allow chilis to be dehydrated in the smoking rack

Describe the solution

Added the "smokable" flag, and "dry_chili" as the smoking result to the chili_pepper json definition

Describe alternatives you've considered

I don't have 1128 of these, so it would've been feasible to do it by hand with the crafting recipe, but I figured I'd fix it while I was fixing the garlic one just in case someone does have 1128 chilis they want to dehydrate

Testing

image
image

Additional context

Adds the "SMOKABLE" flag and "dry_chili" as a smoking result to the "chili_pepper" json definition
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 6, 2024
@PatrikLundell
Copy link
Contributor

PatrikLundell commented Oct 6, 2024

You can debug spawn your 1000+ items when you need to test things like this.

I've bound the debug menu to a key (',' in my case, but that's more or less a random choice), and can then reach the debug spawn option via the menu tree brought up. Quite useful for bug reproduction and code/JSON change testing.

@AudBobb
Copy link
Contributor Author

AudBobb commented Oct 6, 2024

You can debug spawn your 1000+ items when you need to test things like this.

I've bound the debug menu to a key (',' in my case, but that's more or less a random choice), and can then reach the debug spawn option via the menu tree brought up. Quite useful for bug reproduction and code/JSON change testing.

Oh, I know, that was just a dumb joke about my other PR that makes garlic smokable. I made that PR because I had over a thousand garlic that I needed to dehydrate.

@Maleclypse
Copy link
Member

PR summary is broken. I’d fix it but I’m on my phone

@AudBobb
Copy link
Contributor Author

AudBobb commented Oct 6, 2024

PR summary is broken. I’d fix it but I’m on my phone

I think I fixed it? I don't know what I'm doing XD

@Maleclypse Maleclypse merged commit 35153de into CleverRaven:master Oct 7, 2024
23 of 30 checks passed
@Maleclypse
Copy link
Member

Thanks for your contribution!

@AudBobb AudBobb deleted the Adding-chili-peppers-as-a-smokable-item branch October 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants