Small patch to ranged balance test flakiness #76824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Notice the
shot_custom_damage_typetest randomly failing every now and then.Describe the solution
Move the early break below processing the
other_checks. This is the absolutely minimal solution.Also added a capture for the number of times the test ran, could be relevant info sometimes, when the number can vary.
Describe alternatives you've considered
Removing the early break entirely. Not sure how much time that really saves.
Skipping the early break when there's other checks is another option.
Testing
Reproduced the failure with seed
1728104733, didn't fail with the patch.Additional context