Avoid JSON errors on Windows with no sound devices #76782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Avoid JSON errors on Windows with no sound devices"
Purpose of change
One can forget to turn their Bluetooth device and be left without audio devices available.
In that case, the TILES+SOUND built game for Windows reports JSON errors loading soundset.
Describe the solution
Export
sound_init_success
fromsdlsound.cpp
and makeinit_interface()
skip loading sound set at all when it isfalse
.Describe alternatives you've considered
Not sure why
WinCreate()
should initialize audio too.Testing
Compiled, run, load, walk around. No errors (and no audio).
Connect the Bluetooth audio back: same but with audio.
Additional context