Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kill_advanced_inv #76755

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Remove kill_advanced_inv #76755

merged 2 commits into from
Oct 2, 2024

Conversation

alef
Copy link
Contributor

@alef alef commented Oct 1, 2024

Summary

Bugfixes "Fixes AIM layout #76606"

Purpose of change

Fix latest AIM changes to work with saved layout.

Describe the solution

  1. Apply this patch from @Brambor
  2. Make -Werror=missing-declarations happy by inlining the function

Describe alternatives you've considered

None

Testing

Additional context

#76433 Introduced uistate.open_menu. In #76490 @andrei8l commented maybe kill_advanced_inv() could be removed because @Kamayana fixed lot of AIM issues, much probably in #68266.

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 1, 2024
@Maleclypse Maleclypse merged commit 45c3acc into CleverRaven:master Oct 2, 2024
28 checks passed
@alef alef deleted the aim-layout-fix branch October 2, 2024 07:44
@Brambor
Copy link
Contributor

Brambor commented Oct 2, 2024

Thanks for applying my patch and notifying me! Glad it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants