-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner frogs #76680
Cleaner frogs #76680
Conversation
-remove tadpoles: pattern, strange, foul, odd, tail, palette -replace with bigtads: vocal, shift -update upgrades to use GROUP -add obsolete egg items to migration
-remove redundant egg groups -remove eliminated tadpoles from monster_groups -add replacement big tads to groups -add tadpole upgrade groups that allow for elimination of redundant eggs and tadpoles
I think this can still follow what I'm doing in #76211 because the tadpoles cannot be butchered anyway, right? Could you use the same odds I'm using there so we have consistency across vertebrate mutants? So 5% for a mutant outcome |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Correct as far as I know, all of the non-giant tadpoles have the "NO_CORPSE" death function inherited and the two added in this are giant, so use the existing 'mutant_animal_noskin'. I shouldn't need to touch harvest with this PR I agree that it's too high currently; almost guaranteed at least one in each egg drop. I think 10% is more fitting. I plan to address the whole evo/repro cycle in a separate PR. Since there's more need for abstraction with thousands of frog eggs, the rate may need further adjusting. If, for instance, the rot_spawn_chance of the associated egg is reduced to represent the low survival rate of frog eggs and larva |
Summary
None
Purpose of change
Revival of #74240 into the first of several smaller PRs.
Shrink JSON related to amphibian monsters and eggs.
Describe the solution
-Remove redundant mutant eggs and tadpoles
-Replace them by having tadpoles upgrade into monster_groups that include both their natural adult forms and mutant precursor forms
-This effectively shifts the 'mutation point' from fertilization/egg laying to metamorphosis. Natural frogs will no longer lay mutant eggs, instead natural tadpoles may now upgrade into mutants
Describe alternatives you've considered
An over-scoped omnibus PR (#74240) that should be broken up for best practices and for my own sanity.
Testing
Loaded up changes into a fresh world with no errors.
Additional context
Reimplemented from: #74240
Continuation of: #67029