Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] sauropods out of the water #76639

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Sep 24, 2024

Summary

Mods "[DinoMod] sauropods out of the water"

Purpose of change

fix #71220

Describe the solution

Takes advantage of new GROUP_STREAM group to move water loving sauropods out of deep rivers while keeping them connected to the river system. This should produce much more a much more realistic experience.
Renames RIVER predator groups and moves them to STREAM also
Now the only things in the GROUP_RIVER from DinoMod either swim or fly

Describe alternatives you've considered

N/A

Testing

Game loads no errors. Monsters spawn as expected.

Day one river spawn test:
Screenshot 2024-09-23 at 8 44 54 PM

Day one stream spawn test:
Screenshot 2024-09-23 at 8 50 36 PM

Additional context

Thanks to the many players who have requested this fix over the years, and to @Light-Wave for finally creating the infrastructure to make it work

@LyleSY LyleSY added the <Bugfix> This is a fix for a bug (or closes open issue) label Sep 24, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 24, 2024
@LyleSY LyleSY marked this pull request as ready for review September 24, 2024 00:52
@LyleSY LyleSY marked this pull request as draft September 24, 2024 00:54
@LyleSY LyleSY marked this pull request as ready for review September 24, 2024 01:09
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 24, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 24, 2024
@Maleclypse
Copy link
Member

You have a nested mongroup error.

(continued from above) ERROR : src/mongroup.cpp:612 [static void MonsterGroupManager::check_group_definitions()] monster group GROUP_DINOSAUR contains unknown subgroup GROUP_DINOSAUR_PREDATOR_RIVER

@LyleSY
Copy link
Contributor Author

LyleSY commented Sep 29, 2024

Thanks, I was having trouble interpreting that error

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 30, 2024
@Night-Pryanik Night-Pryanik merged commit 856b7eb into CleverRaven:master Oct 1, 2024
24 checks passed
@Torres84f
Copy link

Oh wow thanks, I think I opened this like 3 times over the last 2 years? every time it became STALE.

They told me on the Discord that it was normal for those dinos to be there in the middle of an open sea/lake... like yeah no man there's no sense to that...

I mean of course in streams and somehow smallish lakes but I kept finding them when just going around in my motorboat in the middle of the open sea, like 2 or 3 kms in and that made no sense at all

So yeah thanks for that, I would understnd absolutely it those were marine dinos like the one that eats the Indominus Rex in that Jurassic Park movie, or some sort of Kraken beast but yeah no river dinos go into open sea to "chill"

Thanks a lot, really, 10/10 finally. <3

@LyleSY LyleSY deleted the sauro_upstream branch October 1, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DinoMod] Packs of zombified predatory dinos spawn in the middle of the ocean
4 participants