Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug menu: dialogue menu + talk_topic menu #76566

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ShnitzelX2
Copy link
Contributor

@ShnitzelX2 ShnitzelX2 commented Sep 20, 2024

Summary

Infrastructure "debug dialogue + talk_topic menus"

Purpose of change

Closes #56923

Using any NPC as a vessel, you can test any talk_topic from the debug menu.

Describe the solution

This is a simple integration of avatar::talk_to() into the debug menu. I mostly copied the UI from the vehicle debug menu. Because a selected NPC differs from its expected NPC, don't expect missions or trade to always line up.

Describe alternatives you've considered

Testing

Talked to Hub01, Exodii, and the Warrener from the starting NPC in an evac shelter. Made sure that an NPC must be present to use the talk_topic debug menu.

Additional context

image
image

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 20, 2024
@ShnitzelX2 ShnitzelX2 marked this pull request as draft September 21, 2024 00:17
@ShnitzelX2 ShnitzelX2 marked this pull request as ready for review September 24, 2024 16:36
@ShnitzelX2 ShnitzelX2 marked this pull request as draft September 24, 2024 23:50
-using an NPC as a vessel, test any talk_topic from the debug menu
@ShnitzelX2 ShnitzelX2 marked this pull request as ready for review September 25, 2024 22:01
@Maleclypse Maleclypse merged commit 8cef429 into CleverRaven:master Sep 29, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug menu option to open an existing talk_topic
2 participants