Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't grab a solid vehicle while boarding it #76482

Merged

Conversation

ShnitzelX2
Copy link
Contributor

Summary

Bugfixes "can't grab a solid vehicle while boarding it"

Purpose of change

Yet another follow-up to #76338. The player shouldn't be able to push solid vehicles (e.g. cars) from the inside.

Describe the solution

Checks if vehicle is boarded, then if the vehicle is solid and the grabbed vehicle is the same as the boarded vehicle.

Fixes a bad comparison (using om_id, which was dumb) I made in #76338 that was vital to being able to test this.

Describe alternatives you've considered

Testing

Tested dragging a car normally, attempting to grab a car from the driver's seat and failing, attempting to grab a separate car from the first car and succeeding.

Additional context

image

-also fixes bad vehicle comparison from CleverRaven#76338
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 16, 2024
@Maleclypse Maleclypse merged commit 7b773c1 into CleverRaven:master Sep 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants