Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Rebalance Banked Fire (the item) #76395

Merged
merged 12 commits into from
Sep 14, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Sep 12, 2024

Summary

Mods "[MoM] Rebalance Banked Fire (the item)"

Purpose of change

Talking with someone and they suggested that the actual experience of using Banked Fire in-game doesn't really match the description of it (that there's an open flame burning above your hand).

Describe the solution

Change the following things:

  • Remove the SEMITANGIBLE flag and add 25 encumbrance to one of your hands, representing that you need to keep it open with the flame over it. This encumbrance goes down if you have more hands (4 tentacles, spider arms, etc), though those mutations generally add encumbrance of their own.
  • Add the RESTRICT_HANDS flag, since you can't wield a two-handed weapon if you need one of your hands for Banked Fire. This does not apply if you're a mutant with more than two hands
  • Allow the Banked Flames to increase your fire damage. It still disappears in combat, so you get one hit of increased damage if you're caught unawares (two if you're fast enough because of how event EoCs work).

Describe alternatives you've considered

Testing

Crafting is properly slowed (hard to cook with one hand), two-handed weapons are restricted, and fire damage is increased. Mutations are accounted for.

Additional context

You might ask "Why can't you just directly heat the pan to cook?" and the answer is the same as "Why can't a telekinetic use a computer from across the room?"--the psion doesn't have that degree of fine control. A pyrokinetic can't heat a pan to 175°C and keep it there, they can heat it up burning hot and hope that any pancakes they make aren't charred to the pan. If the flame is over your hand, you can at least control how far the pan is from it and take it off the heat if you need to.

It doesn't have the BOIL quality because BOIL represents a container where boiling can take place, not the ability to boil things.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Mind Over Matter labels Sep 12, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • [Ψ]banked flamess

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 12, 2024
@emixa-d
Copy link

emixa-d commented Sep 12, 2024

If you have 4 or 8 tentacles instead of arms, shouldn't it be possible to use 1 tentacle for the fire and some number between 2 and 7 for cooking? In which case, I wouldn't expect an additional large cooking slowdown from the banked fire (but there still is 30 encumbrance from having tentacles instead of arms and hands).

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Sep 12, 2024

That is true but I think it will have to wait for limbification to really be taken into effect (where having hand_3, hand_4, etc all being encumbrance-free should hopefully lower the overall burden). As it is, the encumbrance is only applied to a single hand. It’s currently not possible to make item encumbrance mutation-conditional.

Edit: actually, there might be something I can do about it

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 12, 2024
@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 12, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 13, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 14, 2024
@Maleclypse Maleclypse merged commit b8b5c5c into CleverRaven:master Sep 14, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the banked-rebalance branch September 15, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants