Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the descriptions of crow and raven so they more accurately describe their relative sizes. #76296

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

MammaJamma88
Copy link
Contributor

@MammaJamma88 MammaJamma88 commented Sep 8, 2024

Summary

Features "Improved description of crow and raven"

Purpose of change

Previously the implication of the crow description is that it is bigger than a raven.

Describe the solution

I changed the descriptions of both the raven and crow delineating the main differences in appearance and sound.

Describe alternatives you've considered

Letting people think that crows are larger than ravens.

Testing

None.

Additional context

@github-actions github-actions bot added new contributor [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Sep 8, 2024
@GuardianDll GuardianDll changed the title changed the descriptions of crow and raven so they more accurately de… changed the descriptions of crow and raven so they more accurately describe their relative sizes. Sep 8, 2024
@NoddingCrow
Copy link
Contributor

This PR has been recommended to me for no particular reason :p

Possible two typos in Raven description, you've written "this glossy black bird had a heavy bead" - I suspect you mean has, present tense, and beak respectively.

Otherwise I like your descriptions, nice work!

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 8, 2024
@GuardianDll
Copy link
Member

GuardianDll commented Sep 8, 2024

For your information, summary is used by the script that harvest the changelog; for it to work and not errorring, it should be either in format

type "description"

Or in format

None

So what you need to do is replace Improved description of crow and raven with Features "Improved description of crow and raven"

Also if you want to follow suggestion of Nodding Crow and edit the text again, you can do it using link https://github.dev/MammaJamma88/Cataclysm-DDA/tree/description_edits

@MammaJamma88
Copy link
Contributor Author

This PR has been recommended to me for no particular reason :p

Possible two typos in Raven description, you've written "this glossy black bird had a heavy bead" - I suspect you mean has, present tense, and beak respectively.

Otherwise I like your descriptions, nice work!

Correct, now how do I fix it?

@GuardianDll
Copy link
Member

Use link above, it will open the editor again, and you'll do the same as you did first time

@MammaJamma88
Copy link
Contributor Author

Use link above, it will open the editor again, and you'll do the same as you did first time

I believe I did it, thanks for being so helpful and patient

@github-actions github-actions bot added <Enhancement / Feature> New features, or enhancements on existing BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 8, 2024
@Maleclypse Maleclypse merged commit 105ee9d into CleverRaven:master Sep 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants