Improved companion order failure reporting somewhat #76193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Try to improve feedback on companion activity failure reasons.
Describe the solution
Split "SKIP_LOCATION" generic failure result on attempts to perform companion activities into several variants to indicate the reason for the failure and than use that result to generate a feedback message.
The reason the reports aren't generated inside the operation is that it's inside a loop where potentially a large number of variants can be checked, which can potentially clutter the log.
One of these failures is then selected for the report if none of the attempts succeeded.
Describe alternatives you've considered
Testing
Much less than I'd like, because I've failed to arrange for most of the error situations.
Failure to reach a construction zone at a roof was produced (and I also found the companion can't use ladders, but will use stairs).
Failure to find a zone was also arranged (dismantle vehicles when the zone doesn't have any vehicle in it).
Additional context