Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some professions & hobbies know Gross Anatomy(+more know new butchering profs) #76159

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

TheShadowFerret
Copy link
Contributor

@TheShadowFerret TheShadowFerret commented Sep 3, 2024

Summary

Content "Professions & hobbies know gross anatomy & new butchering profs"

Purpose of change

Professions & hobbies were not updated in #75340 to give Gross Anatomy, when some of these would contain knowledge of where to hit something. Continuation of #76156.

Describe the solution

Add Gross Anatomy to intermediate/expert melee hobbies, snipers, hunters, CQC/riot police, assassins, doctors, and the Marine(all Marines are trained in knife combat IRL)
Add Ungulate Anatomy to the hunters, because of deer. The shotgun hunter also gets Birds of Flight.
Hunters know basic butchering and skinning.

Describe alternatives you've considered

Also grant Physiology(thus also prereq. Introduction to Biology) to the expert melee hobbies, assassins & snipers.

MMA: Add additional weakpoints referring to combat versus the various enemies of LoZ.

Testing

Create world w/ all changed mods, changes load, scroll the professions.

Additional context

Dr. Erk is still the best melee combatant among the devs

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You know how to properly remove offals from the body.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@TheShadowFerret TheShadowFerret marked this pull request as ready for review September 3, 2024 02:37
@TheShadowFerret TheShadowFerret marked this pull request as draft September 3, 2024 02:38
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: MMA Mythical Martial Arts mod Mods: Innawood 🌲 Anything to do with Innawood mod labels Sep 3, 2024
@TheShadowFerret TheShadowFerret force-pushed the WeakpointProfHob branch 2 times, most recently from 778b24b to 4be2e22 Compare September 3, 2024 03:36
@github-actions github-actions bot added the Bionics CBM (Compact Bionic Modules) label Sep 3, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Sep 3, 2024
Copy link
Member

@GuardianDll GuardianDll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue of working on pending PRs - they can suddenly change their content

data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
@HadeanLake
Copy link
Contributor

fisher prof and fishing hobbists should know something about butchering fish

@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 3, 2024
data/mods/Magiclysm/professions.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/professions.json Outdated Show resolved Hide resolved
@TheShadowFerret TheShadowFerret marked this pull request as ready for review September 3, 2024 13:43
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 3, 2024
@TheShadowFerret TheShadowFerret force-pushed the WeakpointProfHob branch 6 times, most recently from c2147d5 to 0b086ff Compare September 7, 2024 19:10
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 7, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 15, 2024
@Maleclypse Maleclypse merged commit e548bd8 into CleverRaven:master Sep 17, 2024
18 of 24 checks passed
@TheShadowFerret TheShadowFerret deleted the WeakpointProfHob branch September 19, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: MMA Mythical Martial Arts mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants