Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add baby_monster_group #76122

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 1, 2024

Summary

None

Purpose of change

Close #75830

Describe the solution

Add a new field, that picks monsters from mongroup and spawns them as babies

Testing

I can't! I can't find any way that confirms it works, nor any way that confirms that any another method of reproduction works! What the heck? For whatever reason for monsters to actually reproduce you need to visit the place twice. Some troll logic, but it shows it works: cows with attached moose mongroup do spawn monsters from moose mongroup
image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. [Markdown] Markdown issues and PRs <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 1, 2024
@PatrikLundell
Copy link
Contributor

Speculation regarding reproduction "logic" (note: no actual facts!): Need to enter the reality bubble for the impregnation spores to get a chance to do their jobs (no such spores exist, but their "job" may well do) to set off a pregnancy timer, with a second reality bubble entry to effect the birth.
You need a first visit to get eggs laid, and a second one to get them to hatch.

It may also just be a load of hogwash...

@Brambor
Copy link
Contributor

Brambor commented Sep 2, 2024

That sounds like a bug to be reported as a separate issue. To confirm: If I stay in a reality bubble with eggs, they never hatch?

@PatrikLundell
Copy link
Contributor

PatrikLundell commented Sep 2, 2024

No, I didn't mean to say you'd have to leave in between, just that you'd have to be in the bubble to "initiate" the process as well to finish it. Basically that neither egg laying nor hatching happens outside of the bubble, with the speculation that "impregnation" may similarly require bubble presence.
Note that I've probably never stayed in one place without any excursions to actually remain there for the whole laying->hatching duration, but I don't expect it to fail.

Copy link
Contributor

@Brambor Brambor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler/Shorter bool logic.

src/monmove.cpp Outdated Show resolved Hide resolved
GuardianDll and others added 2 commits September 2, 2024 14:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Sep 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 2, 2024
@Maleclypse Maleclypse merged commit 365395d into CleverRaven:master Sep 5, 2024
21 of 26 checks passed
@GuardianDll GuardianDll deleted the mon_group_baby branch September 5, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow baby_monster to support monstergroups
4 participants