Massively increase overmap UI search range #76072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Enhancement / Feature>
|
I can think of one "lock up" issue resulting from a long distance search: The calculation of a path to a location at maximum range. When it comes to path calculations, I'd like those to have some "hang on: this may take time" indications, potentially with some "I'm still working, not locked up" indications. |
github-actions
bot
added
the
BasicBuildPassed
|
Marking this as something I should come back to in terms of pathfinding code. #75945. |
|
Does this fix #69806? |
No, this only affects searches done from the UI search menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Massively increase overmap UI search range"
Purpose of change
Overmap only searches 180 tiles away?! Our missions search as far away as 2400! Surely we can search further than 180?
Describe the solution
Make the search radius FIVE TIMES WIDER! (~24.77x more tiles searched)
Adjust the "No results found" message so it tells you how far it searches. If I had known the range was so short before I would have done this waaaaaaaaaaaaay earlier.
Describe alternatives you've considered
Adjustable search range? Sounds like effort
Testing
Showcasing a successful search from 181 OMTs away, which previously failed. The result is found despite being located on another overmap.
2024-08-30.23-08-08.mp4
Additional context
My only possible concern is performance, but as you can see from the testing it is still instant for my computer.
It looks like the value was previously this low due to performance concerns (see #36816 and linked issues therein), but this is still lightning fast so 🤷.
If performance problems DO appear with this, I'll have to figure something out with
adjustable search rangesmultiple passes, or perhaps another solution (Kevin did not seem to like adjustable ranges, which is fair... you could easily put in a range that'd freeze any computer). That should still easily be possible.