-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Fix the harvest #76049
Merged
Merged
[Magiclysm] Fix the harvest #76049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mods
Issues related to mods or modding
[JSON]
Changes (can be) made in JSON
Mods: Magiclysm
Anything to do with the Magiclysm mod
labels
Aug 30, 2024
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Aug 30, 2024
I noticed #76047 , I think I will convert this PR to that style and wait it merge first |
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 31, 2024
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Sep 1, 2024
Can you fix the conflicts? If not ask in the devcord for some help and people will be able to give you suggestions. |
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Sep 3, 2024
Fixed, looks like the heart PR merge first than mine so the there is the conflict. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Sep 3, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magiclysm] Fix harvest"
Purpose of change
The whole harvest file is a mess, things don't have blood, things don't drop marrow and so on and so forth. This PR is aim to fix them.
Describe the solution
Reference vanilla's harvest file to fix them all.
Describe alternatives you've considered
Testing
Killed a warg, butcher it, it now drop blood and marrow now.Waiting for #76047 merged to test
Additional context