Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Fix the harvest #76049

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

Naadn
Copy link
Contributor

@Naadn Naadn commented Aug 30, 2024

Summary

Mods "[Magiclysm] Fix harvest"

Purpose of change

The whole harvest file is a mess, things don't have blood, things don't drop marrow and so on and so forth. This PR is aim to fix them.

Describe the solution

Reference vanilla's harvest file to fix them all.

Describe alternatives you've considered

Testing

Killed a warg, butcher it, it now drop blood and marrow now.
Waiting for #76047 merged to test

Additional context

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod labels Aug 30, 2024
@github-actions github-actions bot requested a review from KorGgenT August 30, 2024 13:59
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 30, 2024
@Naadn Naadn marked this pull request as draft August 31, 2024 05:27
@Naadn
Copy link
Contributor Author

Naadn commented Aug 31, 2024

I noticed #76047 , I think I will convert this PR to that style and wait it merge first

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 31, 2024
@Naadn Naadn marked this pull request as ready for review September 1, 2024 12:36
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 1, 2024
@Maleclypse
Copy link
Member

Can you fix the conflicts? If not ask in the devcord for some help and people will be able to give you suggestions.

@Naadn Naadn reopened this Sep 3, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 3, 2024
@Naadn
Copy link
Contributor Author

Naadn commented Sep 3, 2024

Can you fix the conflicts? If not ask in the devcord for some help and people will be able to give you suggestions.

Fixed, looks like the heart PR merge first than mine so the there is the conflict.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 3, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 3, 2024
@Maleclypse Maleclypse merged commit 8ba2ab9 into CleverRaven:master Sep 5, 2024
19 of 24 checks passed
@Naadn Naadn deleted the Magic-harvest branch September 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants