Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enchantment for range dodges #75968

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 26, 2024

Summary

None

Purpose of change

Request from discord

Describe the solution

Add an enchantment, that allow to dodge projectile no matter of it's speed

Testing

  {
    "type": "mutation",
    "id": "DEBUG_AAAAAA",
    "name": { "str": "Debug AAAAAAAAAAAAAAAAAAA" },
    "points": 99,
    "valid": false,
    "description": "If you need to survive the deadliest bug attacks.",
    "enchantments": [ { "values": [ { "value": "RANGE_DODGE", "add": 0.99 } ] } ],
    "debug": true
  },

image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions labels Aug 26, 2024
@GuardianDll GuardianDll marked this pull request as ready for review August 26, 2024 17:40
@github-actions github-actions bot requested a review from KorGgenT August 26, 2024 17:41
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 26, 2024
@Maleclypse
Copy link
Member

void Creature::print_proj_avoid_msg( Creature *source, viewer &player_view ) showed up in the clang fail

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 30, 2024
@Maleclypse Maleclypse merged commit d04274a into CleverRaven:master Sep 5, 2024
26 of 27 checks passed
@GuardianDll GuardianDll deleted the dodge_enchantment branch September 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants