Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commentary Cyborg and Robot #75944

Merged

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Aug 25, 2024

Summary

None

Purpose of change

Makes clear why one monster is a ROBOT and one a CYBORG and what are expected to impact the different species of monsters. This gives the answer that a lack of led to #75941.

Describe the solution

Adds comments explaining the differences in multiple locations.

Describe alternatives you've considered

None

Testing

All comment text.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 25, 2024
data/json/ammo_effects.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 25, 2024
@dseguin dseguin merged commit 746a170 into CleverRaven:master Sep 1, 2024
24 checks passed
@Maleclypse Maleclypse deleted the Notes-on-Robots,-Cyborgs-and-Dazzlers branch September 7, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants