Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Island] Make bettter security containers obtainable #75883

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

Naadn
Copy link
Contributor

@Naadn Naadn commented Aug 22, 2024

Summary

Mods "[Sky Island] Make Beta security containers and better ones obtainable."

Purpose of change

There are better security containers than Alpha but unobtainable, I want to fix that.

Describe the solution

Delete the { "math": [ "debug_never_achievable", "==", "1" ] } condition so players can get the upgrade mission.
Make sure player won't keep old container after upgrade. And change the description and message a bit because items in old container no longer lost to void.

Describe alternatives you've considered

Testing

It work, stuffs in old container drop into other pockets after I upgrade it and I don't keep the old container

Additional context

Thanks GuardianDll for point out why upgrade missions is unobtainable.
I hope this time I click the right github button for create PR

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod new contributor labels Aug 22, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 22, 2024
@Maleclypse Maleclypse merged commit ae2b99e into CleverRaven:master Aug 24, 2024
26 of 29 checks passed
@Naadn Naadn deleted the security-container-fix branch August 24, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants