Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOM] Add teleportation ephemeral walk power #75867

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

b3brodie
Copy link
Contributor

@b3brodie b3brodie commented Aug 22, 2024

Summary

Mods "Add Teleportation Ephemeral Walk Power"

Purpose of change

Teleporters could use some more powers
Adds a new concentration power for teleporters that acts similarly to the probability travel CBM.

Describe the solution

Add PHASE_DISTANCE enchant:
Create a new movement function similar to the quantum tunneling instead of expanding the existing one to better support the alternate features.

  • No power usage.
  • No logic based on CBM presence.
  • No messages directly related to how the CBM works (Or at all. I believe they would get a bit spammy).
  • Distance travel is based on inputted distance variable currently directly obtained by the enchantment value. Defaults to 0.
  • Big: allows vertical phasing.
    Vertical Phasing Notes:
  • Hooked up the new function to a couple of areas in the vertical move method as a trigger but leaves the movement in the new function. This is because the vertical_move seems set up to only move 1 level at a time while phasing may involve moving multiple levels at once. With my testing vertical movement functions largely as expected but using other methods of descension / ascension (such as climbing down a wall next to the player) has priority over vertical phasing.

MOM Power:
Adds a difficulty 6 concentration power that hooks up to the new enchant. Uses a similar distance scaling as the phase power. Should include all the normal things involved with adding a new concentration power.

Describe alternatives you've considered

N/A

Testing

Enchant:
Tested that movement without any level of phasing enchant is not effected at all
Tested that phasing allows moving through obstacles
Tested that phasing distance is capped by given value
Tested that phasing vertically works
Tested that moving onto / off of vehicles works

MOM:
Tested that power is learnable
Tested that concentration power toggles as expected
Tested that power correctly gives enchant and allows phasing

Additional context

Vertical phasing was a rabbit hole.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 22, 2024
@Standing-Storm
Copy link
Contributor

Thank you so much for this enchant! I can already think of other uses for it (letting Clairsentients who are astrally projecting just walk through walls instead of needing to use a fake spell to do it, letting XE's Ierde walk through walls while underground, etc).

@github-actions github-actions bot requested a review from KorGgenT August 22, 2024 01:51
@b3brodie b3brodie changed the title [MOM] Add teleportation phasing power [MOM] Add teleportation ephemeral walk power Aug 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 22, 2024
@Maleclypse Maleclypse merged commit 88e7ada into CleverRaven:master Aug 22, 2024
27 of 29 checks passed
@b3brodie b3brodie deleted the mom_powers branch August 22, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants