-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOM] Add teleportation ephemeral walk power #75867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
[C++]
Changes (can be) made in C++. Previously named `Code`
[Markdown]
Markdown issues and PRs
Mechanics: Enchantments / Spells
Enchantments and spells
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Mind Over Matter
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Aug 22, 2024
Thank you so much for this enchant! I can already think of other uses for it (letting Clairsentients who are astrally projecting just walk through walls instead of needing to use a fake spell to do it, letting XE's Ierde walk through walls while underground, etc). |
b3brodie
changed the title
[MOM] Add teleportation phasing power
[MOM] Add teleportation ephemeral walk power
Aug 22, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
<Documentation>
Design documents, internal info, guides and help.
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Add Teleportation Ephemeral Walk Power"
Purpose of change
Teleporters could use some more powers
Adds a new concentration power for teleporters that acts similarly to the probability travel CBM.
Describe the solution
Add PHASE_DISTANCE enchant:
Create a new movement function similar to the quantum tunneling instead of expanding the existing one to better support the alternate features.
Vertical Phasing Notes:
MOM Power:
Adds a difficulty 6 concentration power that hooks up to the new enchant. Uses a similar distance scaling as the phase power. Should include all the normal things involved with adding a new concentration power.
Describe alternatives you've considered
N/A
Testing
Enchant:
Tested that movement without any level of phasing enchant is not effected at all
Tested that phasing allows moving through obstacles
Tested that phasing distance is capped by given value
Tested that phasing vertically works
Tested that moving onto / off of vehicles works
MOM:
Tested that power is learnable
Tested that concentration power toggles as expected
Tested that power correctly gives enchant and allows phasing
Additional context
Vertical phasing was a rabbit hole.